Skip to content

Benchmarking: add QUERIES custom variable - #1075

Merged
pflanze merged 3 commits into
mainfrom
benchmarking_add_QUERIES_custom_variable
Dec 3, 2025
Merged

Benchmarking: add QUERIES custom variable#1075
pflanze merged 3 commits into
mainfrom
benchmarking_add_QUERIES_custom_variable

Conversation

@pflanze

@pflanze pflanze commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

Summary

For testing with a different set of queries, read the optional QUERIES env variable; if unset or empty, use "queries" as the value. It denotes the name of the directory below the DATASET_DIR, where all files for the api-query tool are to be found:

good-api-query-log.csv
ignore_queries_for_checksum_regex.txt
queries.ndjson

This change also automatically stores the CSV log file from api-query as good-api-query-log.csv in that location, if the file does not exist yet. This is assuming that the file is OK, later comparisons will reveal when not right. (A bit like ssh storing the fingerprint when connecting for the first time.)

PR Checklist

  • All necessary documentation has been adapted or there is an issue to do so.
  • [ ] The implemented feature is covered by an appropriate test.

@pflanze pflanze self-assigned this Dec 1, 2025
@github-actions

github-actions Bot commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog.

Note that this might contain changes that are on main, but not yet released.

Changelog:

0.9.2 (2025-12-01)

Features

  • benchmarking: add DEBUG custom variable for running debug builds (541afc8)
  • benchmarking: add optional QUERIES custom variable (7831fed)
  • benchmarking: update api-query to ignore empty ignore regex files (63a619d)
  • benchmarking: update api-query, enable CSV log file w/ checksum comparisons (3d135d0)
  • build: tag images with branch name again (670817c)
  • documentation: add documentation for sequence storage format (47e4081)
  • silo: add efficient way of computing vertical coverage bitmaps and use them to adapt reference positions (8e7e9f4)
  • silo: better compression for sequences (9eb69c7)
  • silo: enable rewrite of SymbolInSet expressions under Or (5489117)
  • silo: split compile function into separate rewrite step (27b7e7c)

Bug Fixes

  • build: correctly fix the cppstd for installing the arrow dependency (0c4aed3)
  • build: fix Makefile to not repeatedly invoke conan install (346e6a9)
  • silo: do not add empty coverage bitmaps (5bd32c7)

@pflanze
pflanze requested a review from taepper December 1, 2025 21:53

@taepper taepper left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pflanze
pflanze merged commit 51fbf91 into main Dec 3, 2025
15 of 16 checks passed
@pflanze
pflanze deleted the benchmarking_add_QUERIES_custom_variable branch December 3, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants